Skip to content

Fixes a wrong not node insertion producing broken lir range on macos arm64 #77166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 1 commit into from
Oct 18, 2022
Merged

Fixes a wrong not node insertion producing broken lir range on macos arm64 #77166

jakobbotsch merged 1 commit into from
Oct 18, 2022

Conversation

@En3Tho
Copy link
Contributor

@En3Tho En3Tho commented Oct 18, 2022 •
edited
Loading

Fixes #77158
Inserting not node before andOp2 was producing a faulty LIR range. Inserting after andOp1 fixes this. I thought this optimization was not affecting arm64 since there were no spmi diffs.

@jakobbotsch was spot on :)

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Oct 18, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #77158

Author: En3Tho
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@En3Tho
Copy link
Contributor Author

En3Tho commented Oct 18, 2022

Running Test: B282745.testMDArrayWith3Dimensions

cmdLine:D:\a_work\1\s\artifacts\tests\coreclr\windows.x64.Debug\nativeaot\SmokeTests\DynamicGenerics\DynamicGenerics\DynamicGenerics.cmd Timed Out (timeout in milliseconds: 1800000 from variable __TestTimeout, start: 10/18/2022 4:25:48 PM, end: 10/18/2022 4:55:48 PM)
Test Harness Exitcode is : -100
To run the test:

set CORE_ROOT=D:\a_work\1\s\artifacts\tests\coreclr\windows.x64.Debug\Tests\Core_Root
D:\a_work\1\s\artifacts\tests\coreclr\windows.x64.Debug\nativeaot\SmokeTests\DynamicGenerics\DynamicGenerics\DynamicGenerics.cmd

Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary

1805.495 | 17 | 16 | 1 | 0 | nativeaot.SmokeTests.XUnitWrapper.dll

1805.495 | 17 | 16 | 1 | 0 | (total)

Creating repro files at: D:\a_work\1\s\artifacts\repro\windows.x64.Debug
Repro files written.
##[error]Cmd.exe exited with code '1'.
Finishing: Run tests in single file mode

@En3Tho
Copy link
Contributor Author

En3Tho commented Oct 18, 2022

Is this a known thing?

@build-analysis build-analysis bot mentioned this pull request Oct 18, 2022
Closed
@jakobbotsch
Copy link
Member

jakobbotsch commented Oct 18, 2022

Yes, the failure is #76801 according to build analysis. The superpmi-replay failure is a timeout that we've seen before as well.

Thanks for quickly fixing this!

@jakobbotsch jakobbotsch merged commit e7ca4a8 into dotnet:main Oct 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed 'next != def && "found def after use"' during 'Lowering nodeinfo'

2 participants

@En3Tho @jakobbotsch