[PERF] Fix Linux arm64 AOT ROOTFS_DIR missing #77024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @hoyosjs Issue DetailsAdded crossrootfsDir parameter to AOT job pointing to crossrootfsDir for the arm64 run and removed 'jobParameters.' from the assignment in global-build-job as was not correctly passing the crossrootfsDir parameter. /cc:@am11 I noticed that the crossrootfsDir parameter condition was added as part of #75513, do you know of anywhere currently using this successfully as is before changing the global build job? I think the condition without the 'jobParameter.' is the correct format but want to make sure there isn't a different way the does work with the current setup.
|
Member
Author
|
Closing in deference to #77027. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added crossrootfsDir parameter to AOT job pointing to crossrootfsDir for the arm64 run and removed 'jobParameters.' from the assignment in global-build-job as was not correctly passing the crossrootfsDir parameter. This seems to have been broken by: 3c99def.
The addition of crossrootfsDir condition was recent in #75513, I think that this new format is the correct one given jobParameters is not used as a parameter group elsewhere in the global-build-job.yml.
Run showing the 'Build Linux arm64 release AOT' job running successfully: https://dev.azure.com/dnceng/internal/_build/results?buildId=2020079&view=results.