Skip to content

Fixing where ClearContained is called for certain Arm64 cast ops #76517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tannergooding merged 2 commits into from
Oct 4, 2022
Merged

Fixing where ClearContained is called for certain Arm64 cast ops #76517

tannergooding merged 2 commits into from
Oct 4, 2022

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Oct 2, 2022

This resolves #76511

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 2, 2022
@ghost ghost assigned tannergooding Oct 2, 2022
@ghost
Copy link

ghost commented Oct 2, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This resolves #76511

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@tannergooding
Copy link
Member Author

tannergooding commented Oct 3, 2022

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 3, 2022

Azure Pipelines successfully started running 4 pipeline(s).

@tannergooding tannergooding mentioned this pull request Oct 3, 2022
Merged
@tannergooding
Copy link
Member Author

tannergooding commented Oct 3, 2022

AV failures need: #76532

@tannergooding
Copy link
Member Author

tannergooding commented Oct 3, 2022

The failure for Runtime_40607 is #76546

@tannergooding
Copy link
Member Author

tannergooding commented Oct 3, 2022

CC. @dotnet/jit-contrib

This resolves #76511. Failures all look to be known. It might be desirable to wait to merge this until after #76532 goes in since that will fix most of the AVs.

@tannergooding
Copy link
Member Author

tannergooding commented Oct 3, 2022

Merged in main to pickup #76532

@tannergooding
Copy link
Member Author

tannergooding commented Oct 3, 2022

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 3, 2022

Azure Pipelines successfully started running 4 pipeline(s).

@tannergooding tannergooding merged commit c23241b into dotnet:main Oct 4, 2022
@tannergooding tannergooding deleted the fix-76511 branch October 4, 2022 02:26
@tannergooding
Copy link
Member Author

tannergooding commented Oct 4, 2022

jitstress failures were all known:

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tannergooding tannergooding

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion failed '!op1->isUsedFromMemory()'

2 participants

@tannergooding @BruceForstall