SmtpClientTest Assertion Fail Fix#76361
Merged
liveans merged 15 commits intodotnet:mainfrom Oct 24, 2022
Merged
Conversation
liveans
added
NO-MERGE
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsTrying to collect some information from CI and will try to fix #72830
|
2 tasks
liveans
removed
NO-MERGE
liveans
changed the title
tmds
reviewed
Oct 19, 2022
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Unix.cs
Outdated
Show resolved
Hide resolved
antonfirsov
reviewed
Oct 19, 2022
Contributor
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
Would be good to see a repro stressing the race between the multi-connect and the socket disposal. Ideally, we should be able to turn this repro into a test.
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Unix.cs
Outdated
Show resolved
Hide resolved
Member
|
CI fails look related to the change. |
Member
Author
Yeah, I'll look at it, today. |
antonfirsov
reviewed
Oct 21, 2022
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Unix.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Firszov <[email protected]>
tmds
reviewed
Oct 21, 2022
src/libraries/System.Net.Mail/tests/Functional/SmtpClientTest.cs
Outdated
Show resolved
Hide resolved
…t-runtime into ignore-test-mail-assertion
Member
Author
|
I'm merging this, I can create seperate PR for any further review @antonfirsov @wfurt @tmds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReplaceHandleis the only function that we're changing the_handlemember variable outside of the constructor.This change worth to try.
Fixes #72830