Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@carlossanlop how do I run the completeness check on this ?

@carlossanlop how do I run the completeness check on this ?

The undoc APIs report is generated in dotnet-api-docs, not on runtime. So the only way to validate that this PR is complete, is by making sure the list of undoc APIs I provided in the issue is covered in this PR.

Please help port the undoc APIs to dotnet-api-docs as well. That repo is the source of the intellisense package we ship to customers. We generate it there after the text goes through language review.

@pavelsavara to port your triple slash comments to dotnet-api-docs, use the https://github.com/dotnet/api-docs-sync/ tool.

1. Install the tool using the .\install-as-tool.ps1 script. The tool is PortToDocs.exe.
2. For your specific case, you need to pre-build your runtime repo for wasm, so the intellisense xml file is generated for that architecture.
3. Clone the dotnet-api-docs repo locally.
4. Example of the command you would execute:

PortToDocs.exe -Docs D:\dotnet-api-docs\xml -IntelliSense D:\runtime7\artifacts\bin\System.Runtime.InteropServices.JavaSc
ript\Release\net7.0-browser -IncludedAssemblies "System" -IncludedNamespaces "System" -Save true

Assumptions of the example:

• Your repos live in the D:\ drive.
• You built runtime in Release for browser.
• Your undoc APIs fullname DocIDs start with System, both in the assembly and the namespace.

I created dotnet/dotnet-api-docs#8436 and generated the docs into via the tool.
The tools also gives feedback about missing docs!

I didn't know how to create namespace doc in the runtime repo so I wrote it by hands in the dotnet-api-docs PR

I didn't know how to create namespace doc in the runtime repo so I wrote it by hands in the dotnet-api-docs PR

Thanks. Yep, that was the right way to do it. It can't be ported.

many thanks @carlossanlop

Marked this as breaking since it removes an implicit public default constructor. cc @lewing