Skip to content

Fix building CLR test tree#74547

Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom
MichalStrehovsky:testbld
Aug 25, 2022
Merged

Fix building CLR test tree#74547
MichalStrehovsky merged 1 commit intodotnet:mainfrom
MichalStrehovsky:testbld

Conversation

@MichalStrehovsky
Copy link
Member

  • If we're only building Pri-0 tests, don't try to AOT compile Pri-1 tests. _WillCLRTestProjectBuild is the property that checks for that.
  • Targeting pack references get injected in a way that the compiler targets don't see. The compiler targets are written for publish scenarios but we're not doing a publish.

Fixes #68394

* If we're only building Pri-0 tests, don't try to AOT compile Pri-1 tests. `_WillCLRTestProjectBuild` is the property that checks for that.
* Targeting pack references get injected in a way that the compiler targets don't see. The compiler targets are written for publish scenarios but we're not doing a publish.
@MichalStrehovsky MichalStrehovsky merged commit 3eccadf into dotnet:main Aug 25, 2022
@MichalStrehovsky MichalStrehovsky deleted the testbld branch August 25, 2022 08:02
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot run tests outside of nativeaot folder

3 participants