#50575 colorbehavior default should disable colors in android/applemobile#74496
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -157,8 +158,12 @@ private static string GetLogLevelString(LogLevel logLevel) | |||
|
|
|||
| private ConsoleColors GetLogLevelConsoleColors(LogLevel logLevel) | |||
There was a problem hiding this comment.
Would it be better to have a mobile specific .cs file that implemented a function that returned true for disableColors?
There was a problem hiding this comment.
We don't build RID specific versions of these libraries, and don't really plan on adding them. It impacts the build times of these libraries.
See also #53900.
cc @ViktorHofer
There was a problem hiding this comment.
Yes, we don't want OOB libraries to have runtime specific build configurations. Instead they are better of using runtime configurations when possible.
src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs
Show resolved
Hide resolved
|
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger |
…tcoreapp configs (#74798) We can keep the previous behavior before #74496 on non-netcoreapp configs since they only apply to legacy Xamarin.iOS/Android. That allows us to use the more efficient `OperatingSystem.Is*()` APIs. Co-authored-by: Jan Kotas <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
5 participants
Fix #50575 and #51398