Use {Last}IndexOfAnyExcept in RegexCompiler and source generator #73910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In almost every place we use {Last}IndexOf{Any} for a given character or set of characters, we can use {Last}IndexOfAnyExcept for the negated counterpart. This leads to cleaner generated code, and for longer searches, benefits from vectorization. This includes:
The two places we don't currently use IndexOf* but don't use the *Except variants are: