Skip to content

Unify MaxResponseHeadersLength calculations #73907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MihaZupan merged 7 commits into from
Aug 15, 2022
Merged

Unify MaxResponseHeadersLength calculations #73907

MihaZupan merged 7 commits into from
Aug 15, 2022

Conversation

@MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Aug 13, 2022

Fixes #73848

@MihaZupan MihaZupan added this to the 7.0.0 milestone Aug 13, 2022
@MihaZupan MihaZupan marked this pull request as ready for review August 13, 2022 20:25
@ghost ghost assigned MihaZupan Aug 13, 2022
@ghost
Copy link

ghost commented Aug 13, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73848

Author: MihaZupan
Assignees: -
Labels:

area-System.Net.Http
Milestone: 7.0.0

@MihaZupan MihaZupan requested a review from a team August 13, 2022 20:25
stephentoub
stephentoub approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing a test?

@MihaZupan
Copy link
Member Author

MihaZupan commented Aug 13, 2022 •
edited
Loading

We have an existing test that checks that we enforce the limit, but we don't check inputs that would overflow - added that.

Actually, it looks like that existing test is limited to 1.1 :/ Let me fix that

@MihaZupan MihaZupan requested a review from stephentoub August 13, 2022 23:58
@stephentoub
Copy link
Member

stephentoub commented Aug 14, 2022

The tests are failing with the WinHTTP variants.

@MihaZupan MihaZupan merged commit 3968ceb into dotnet:main Aug 15, 2022
@ManickaP ManickaP mentioned this pull request Aug 15, 2022
Closed
@CarnaViire CarnaViire mentioned this pull request Aug 24, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JamesNK JamesNK JamesNK approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees

@MihaZupan MihaZupan

Labels

area-System.Net.Http

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

SocketsHttpHandler.MaxResponseHeadersLength can cause internal 32-bit overflow with HTTP/2

3 participants

@MihaZupan @stephentoub @JamesNK