Skip to content

[wasm] Move all the wasm jobs from runtime-staging to runtime#73596

Merged
radical merged 5 commits intodotnet:mainfrom
radical:ci-move-jobs-to-runtime
Aug 25, 2022
Merged

[wasm] Move all the wasm jobs from runtime-staging to runtime#73596
radical merged 5 commits intodotnet:mainfrom
radical:ci-move-jobs-to-runtime

Conversation

@radical
Copy link
Member

@radical radical commented Aug 8, 2022

  • library tests: windows
  • AOT tests: windows
  • Debugger tests (chrome): windows, and linux
  • Wasm.Build.Tests: windows
  • Debugger tests for Firefox - moved to runtime-extra-platforms, and runtime-wasm

- library tests: windows
- AOT tests: windows
- Debugger tests (chrome): windows, and linux
- Wasm.Build.Tests: windows
@ghost
Copy link

ghost commented Aug 8, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • library tests: windows
  • AOT tests: windows
  • Debugger tests (chrome): windows, and linux
  • Wasm.Build.Tests: windows
Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

@ghost ghost assigned radical Aug 8, 2022
@steveisok steveisok requested a review from a team August 24, 2022 21:57
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@radical radical changed the title [wasm] Move stable jobs from runtime-staging to runtime [wasm] Move all the wasm jobs from runtime-staging to runtime Aug 24, 2022
@radical
Copy link
Member Author

radical commented Aug 24, 2022

@trylek @steveisok @akoeplinger Is it acceptable to have a job in runtime which is known to have test failures, and thus the job has continueOnError: true?

@hoyosjs
Copy link
Member

hoyosjs commented Aug 24, 2022

this means that WASM tests will always run for SetPathVars_libraries.containsChange -> do we have enough to do WASM tests on every library change?

@radical
Copy link
Member Author

radical commented Aug 24, 2022

this means that WASM tests will always run for SetPathVars_libraries.containsChange -> do we have enough to do WASM tests on every library change?

This doesn't change the existing state. Wasm does use the libraries, so running tests for those makes sense to me. We already have CI holes due to running fewer tests on PRs, which sometimes causes changes that break wasm to get into main.

@lewing
Copy link
Member

lewing commented Aug 24, 2022

@trylek @steveisok @akoeplinger Is it acceptable to have a job in runtime which is known to have test failures, and thus the job has continueOnError: true?

which tests?

@radical
Copy link
Member Author

radical commented Aug 24, 2022

@trylek @steveisok @akoeplinger Is it acceptable to have a job in runtime which is known to have test failures, and thus the job has continueOnError: true?

which tests?

Firefox debugger tests

@trylek
Copy link
Member

trylek commented Aug 24, 2022

Regarding @radical's question, if the failing job with continueOnError in runtime makes the pipeline report as red, that's something we should avoid as it's the primary health indicator everyone's looking at; if the AzDO pipeline summary ends up showing all crosses in red circles, that's not good even if we convince ourselves that the tests semantically passed.

@radical
Copy link
Member Author

radical commented Aug 24, 2022

  • In runtime-staging at least test failures make the job show up as orange. I'm guessing that it would be the same case for runtime? But would it show up as red for rolling builds?
  • In the orange case too, the failures show up in kusto though. I don't how the CI runs are monitored though

I'm talking specifically about test failures.

@steveisok
Copy link
Member

steveisok commented Aug 24, 2022

  • In runtime-staging at least test failures make the job show up as orange. I'm guessing that it would be the same case for runtime? But would it show up as red for rolling builds?
  • In the orange case too, the failures show up in kusto though. I don't how the CI runs are monitored though

I'm talking specifically about test failures.

Would it be better to only execute the tests in runtime-extra-platforms?

My thinking is that the errors will only matter to a subset of people, so why not manage it post PR.

@radical
Copy link
Member Author

radical commented Aug 24, 2022

  • In runtime-staging at least test failures make the job show up as orange. I'm guessing that it would be the same case for runtime? But would it show up as red for rolling builds?
  • In the orange case too, the failures show up in kusto though. I don't how the CI runs are monitored though

I'm talking specifically about test failures.

Would it be better to only execute the tests in runtime-extra-platforms?

My thinking is that the errors will only matter to a subset of people, so why not manage it post PR.

That makes sense. But one problem is that the dev will need to run runtime-wasm pipeline, which has lots of other wasm jobs including all the AOT ones, which won't be needed for a PR with only debugger changes.

We could move it there though, if there aren't any good alternatives.

@radical
Copy link
Member Author

radical commented Aug 25, 2022

Done. Moved the Firefox debugger tests jobs, which has the failures, to runtime-extra-platforms.

@radical
Copy link
Member Author

radical commented Aug 25, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

```
src/mono/sample/wasm/browser-eventpipe/Program.cs(80,13): error IDE0074: (NETCORE_ENGINEERING_TELEMETRY=Build) Use compound assignment
```
@ViktorHofer
Copy link
Member

That makes sense. But one problem is that the dev will need to run runtime-wasm pipeline, which has lots of other wasm jobs including all the AOT ones, which won't be needed for a PR with only debugger changes.

FWIW, there's always the possibility to introduce another pipeline and trigger it via an /azp command...

@steveisok
Copy link
Member

FWIW, there's always the possibility to introduce another pipeline and trigger it via an /azp command...

I'm starting to think we're going to need more pipelines :-).

@radical
Copy link
Member Author

radical commented Aug 25, 2022

The failure is #74588 .

@radical radical merged commit e130a89 into dotnet:main Aug 25, 2022
@radical radical deleted the ci-move-jobs-to-runtime branch August 25, 2022 15:25
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants