Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

We currently only cover Release runtime + Release libs. This is probably the mainstream user scenario.

  • We need coverage with Checked Runtime+Compiler & Release libs. Alternatively we could make the mainstream testing use Checked bits?
  • We need coverage for Debug libraries. Using only Checked runtime+compiler should be fine for that.

@ghost
Copy link

ghost commented Aug 8, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@ghost ghost assigned MichalStrehovsky Aug 8, 2022
@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jobParameters:
testGroup: innerloop
isSingleFile: true
nameSuffix: NativeAOT_Checked_Libs_Passing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if there is no _Failing counterpart template, should we simplify it and remove _Passing from these suffixes?
e.g. coreclr and mono legs also have exclusions but no such suffix was used there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I haven't exactly been a fan when the suffix was introduced either.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Aug 11, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

We currently only cover Release runtime + Release libs. This is probably the mainstream user scenario.

  • We need coverage with Checked Runtime+Compiler & Release libs. Alternatively we could make the mainstream testing use Checked bits?
  • We need coverage for Debug libraries. Using only Checked runtime+compiler should be fine for that.
Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-Infrastructure

Milestone: -

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

Closing in favor of #79847.

@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch December 20, 2022 08:57
@ghost ghost locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants