Remove static readonly fields from X500NameEncoder #73115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsSwitch out
|
vcsjones
commented
Jul 30, 2022
| private static List<byte[]> ParseDistinguishedName( | ||
| string stringForm, | ||
| List<char> dnSeparators, | ||
| string dnSeparators, |
Member
Author
There was a problem hiding this comment.
The only thing dnSeparators is used for is for calling .Contains(char) which is already ordinal based, so nothing else needed to change for changing to a string.
stephentoub
approved these changes
Aug 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch out
List<char>forconst string. A static constructor is no longer emitted for this class.