Implement new API GetEnumValuesAsUnderlyingType #73057

LakshanF · 2022-07-29T11:30:14Z

Implemented the new API in Type and the two static API's in Enum calling the Type implementation. The abstract Type implementation throws with the expectation that a derived runtime Type will provide its own implementation.
CoreCLR/Mono has an override implementation and NativeAOT has its own implementation that mirrors the original PR Make Enum.GetValues AOT-safe #72236.
Also added an override in MetadataAssemblyLoadContext that is reflection friendly
Added some test scenarios with the most on EnumTests

ghost · 2022-07-29T11:30:20Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2022-07-29T11:30:42Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #72498,

Implemented the new API in Type and the two static API's in Enum calling the Type implementation
CoreCLR/Mono has an override implementation and NativeAOT has its own implementation that mirrors the original PR Make Enum.GetValues AOT-safe #72236
Also added an override in MetadataAssemblyLoadContext that is reflection friendly
Added some test scenarios with the most on EnumTests

Author:	LakshanF
Assignees:	-
Labels:	`area-System.Reflection`, `new-api-needs-documentation`, `CoreClr`
Milestone:	-

eerhardt · 2022-07-29T14:06:59Z

Can you also change the upstack code to use this? That way we can ensure it is working correctly?

Ex.

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs

Lines 174 to 179 in 20b42d5

    
           Array objValues = Enum.GetValues(EnumType); 
        
           long[] ulValues = new long[objValues.Length]; 
        
           for (int idx = 0; idx < objValues.Length; idx++) 
        
           { 
        
               ulValues[idx] = GetEnumValue(isUnderlyingTypeUInt64, (Enum)objValues.GetValue(idx)!, culture); 
        
           }

src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs

src/libraries/System.Runtime/ref/System.Runtime.cs

...ries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoType.cs

Co-authored-by: Jan Kotas <[email protected]>

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs

src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs

src/tests/nativeaot/SmokeTests/Reflection/Reflection.cs

Co-authored-by: Jan Kotas <[email protected]>

src/tests/nativeaot/SmokeTests/Reflection/Reflection.cs

...ries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoType.cs

…/Reflection/TypeLoading/Types/RoType.cs

jkotas

LGTM. Thank you!

src/libraries/System.Reflection/tests/TypeInfoTests.cs

src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs

…Tests/Type/TypeTests.cs

src/libraries/System.Private.CoreLib/src/System/Type.cs

Co-authored-by: Jan Kotas <[email protected]>

src/libraries/System.Private.CoreLib/src/System/Enum.cs

src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs

Co-authored-by: Stephen Toub <[email protected]>

src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs

Co-authored-by: Jan Kotas <[email protected]>

src/libraries/System.Private.CoreLib/src/System/Enum.cs

jkotas

Thanks

src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs

Co-authored-by: Jan Kotas <[email protected]>

Implement new API GetEnumValuesAsUnderlyingType

f2a57e6

LakshanF added the CoreClr label Jul 29, 2022

LakshanF requested review from MichalStrehovsky, eerhardt and jkotas July 29, 2022 11:30

ghost added area-System.Reflection new-api-needs-documentation labels Jul 29, 2022

ghost assigned LakshanF Jul 29, 2022

jkotas reviewed Jul 29, 2022

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs Outdated Show resolved Hide resolved

jkotas reviewed Jul 29, 2022

View reviewed changes

src/libraries/System.Runtime/ref/System.Runtime.cs Outdated Show resolved Hide resolved

jkotas reviewed Jul 29, 2022

View reviewed changes

...ries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoType.cs Show resolved Hide resolved

jkotas reviewed Jul 29, 2022

View reviewed changes

...ries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoType.cs Outdated Show resolved Hide resolved

LakshanF and others added 2 commits July 29, 2022 09:25

Update src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs

95d423f

Co-authored-by: Jan Kotas <[email protected]>

FB

5a348ca