Remove a few hardcoded instances of "net7.0"#72950
Merged
akoeplinger merged 1 commit intodotnet:mainfrom Jul 27, 2022
Merged
Conversation
Follow-up to dotnet#71129. The xunit runner package defines a property `XunitConsoleNetCore21AppPath` which (despite the name) points to the xunit.console.dll, we can use that instead. The properties for the workloads/installer tasks aren't needed either since the packages already define them.
ghost
assigned
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFollow-up to #71129. The xunit runner package defines a property The properties for the workloads/installer tasks aren't needed either since the packages already define them.
|
steveisok
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #71129.
The xunit runner package defines a property
XunitConsoleNetCore21AppPathwhich (despite the name) points to the xunit.console.dll, we can use that instead.The properties for the workloads/installer tasks aren't needed either since the packages already define them.