Get more libraries tests running with NativeAOT#72917
Merged
MichalStrehovsky merged 3 commits intodotnet:mainfrom Jul 29, 2022
Merged
Get more libraries tests running with NativeAOT#72917MichalStrehovsky merged 3 commits intodotnet:mainfrom
MichalStrehovsky merged 3 commits intodotnet:mainfrom
Conversation
* MetadataLoadContext tests need more work for single file testing in general. Filed a separate issue. * S.R.Intrinsics is now clean. Running it on NativeAOT found good JIT bugs (dotnet#72081, dotnet#72158). Promoting to a smoke test. * S.Drawing.Primitives was testing DataContractSerializer for whatever reason. Marked that as aggresive trimming incompatible. This wouldn't be covered by dotnet#72910. * Made S.R.InteropServices.ComDisabled fully pass by fixing exceptions we throw. * A couple tests won't ever make sense to run on NativeAOT so removed them from triage area.
ghost
added
the
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 27, 2022
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
jkotas
reviewed
Jul 29, 2022
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.InteropServices.RuntimeInformation\tests\System.Runtime.InteropServices.RuntimeInformation.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader\tests\DefaultContext\System.Runtime.Loader.DefaultContext.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader\tests\RefEmitLoadContext\System.Runtime.Loader.RefEmitLoadContext.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Serialization.Formatters\tests\System.Runtime.Serialization.Formatters.Tests.csproj" /> |
Member
There was a problem hiding this comment.
System.Runtime.Serialization.Formatters is binary serialization that's not supported by design. This can be also moved to the non-interesting category.
Member
Author
There was a problem hiding this comment.
I want to at least have a quick look at the results first - many tests are already marked as conditional on IsBinaryFormatterSupported and this has tests for FormatterServices that have NativeAOT specifics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc @dotnet/ilc-contrib