[mini] Emit a null check using MONO_EMIT_NEW_CHECK_THIS for GetArrayDataReference #72897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ataReference using MONO_EMIT_NULL_CHECK does not emit a null check in the backend if the pointer is otherwise unused Fixes dotnet#72745
ghost
added
the
lambdageek
changed the title
Contributor
|
Note that the tests for this are currently only in #72725. |
vargaz
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using MONO_EMIT_NULL_CHECK does not emit a null check in the backend
if the pointer is otherwise unused
Fixes #72745