Disable ReadAsync_CancelPendingValueTask_ThrowsCancellationException for Http1#72854
Merged
CarnaViire merged 1 commit intodotnet:mainfrom Jul 27, 2022
Merged
Disable ReadAsync_CancelPendingValueTask_ThrowsCancellationException for Http1#72854CarnaViire merged 1 commit intodotnet:mainfrom
CarnaViire merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #72586. I checked test result DB and it seems that only the variant in Http1CloseResponseStreamConformanceTests hangs.
|
Member
It's surprising that on the raw version the task case would hang but the valuetask one wouldn't. |
Member
|
I see this locally: The problem is not in the |
CarnaViire
approved these changes
Jul 27, 2022
Member
CarnaViire
left a comment
CarnaViire
left a comment
There was a problem hiding this comment.
Let's get the disabling in so it wouldn't hurt others, and investigate later
This was referenced Jul 27, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #72586.
I checked test result DB and it seems that only the variant in Http1CloseResponseStreamConformanceTests hangs.