Replace a static readonly int[] in System.Data.Common #72743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a small number of values, all within the byte range.
ghost
added
the
|
Tagging subscribers to this area: @roji, @ajcvickers Issue DetailsThere are a small number of values, all within the byte range. Also renamed the consts to make it clearer (according to our style) that they are, since that matters for the span-based optimization.
|
stephentoub
changed the title
roji
approved these changes
Jul 24, 2022
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Just to make sure you're aware that this is the part of System.Data which is effectively archived (used only in DataTAble/DataSet), and micro-optimizing here is probably unlikely to have a significant overall effect.
Member
Author
|
Yup, thanks. It's mainly to get it off my radar. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a small number of values, all within the byte range.
Also renamed the consts to make it clearer (according to our style) that they are, since that matters for the span-based optimization.
(Last case extracted from #70179)