Skip to content

Add CertificateRevocationListBuilder #72708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bartonjs merged 5 commits into from
Jul 26, 2022
Merged

Add CertificateRevocationListBuilder #72708

bartonjs merged 5 commits into from
Jul 26, 2022

Conversation

@bartonjs
Copy link
Member

@bartonjs bartonjs commented Jul 23, 2022

This adds CRLBuilder, without the static method to create a CDP extension.

It still needs a lot of tests (ccov is only at 55% and Load is entirely untested), but throwing up a draft for any interested early eyeballs.

@bartonjs bartonjs added this to the 7.0.0 milestone Jul 23, 2022
@bartonjs bartonjs self-assigned this Jul 23, 2022
@ghost
Copy link

ghost commented Jul 23, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 23, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds CRLBuilder, without the static method to create a CDP extension.

It still needs a lot of tests (ccov is only at 55% and Load is entirely untested), but throwing up a draft for any interested early eyeballs.

Author: bartonjs
Assignees: bartonjs
Labels:

area-System.Security, cryptographic-docs-impact
Milestone: 7.0.0

@vcsjones vcsjones self-requested a review July 23, 2022 00:28
vcsjones
vcsjones reviewed Jul 24, 2022
View reviewed changes
Copy link
Member

@vcsjones vcsjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't comment on tests since those are in-flight.

@bartonjs bartonjs marked this pull request as ready for review July 25, 2022 23:18
vcsjones
vcsjones reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@vcsjones vcsjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some small questions.

@bartonjs bartonjs merged commit edb30e7 into dotnet:main Jul 26, 2022
@bartonjs bartonjs deleted the crlbuilder branch July 26, 2022 16:37
@bartonjs bartonjs added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Aug 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vcsjones vcsjones vcsjones approved these changes

Assignees

@bartonjs bartonjs

Labels

area-System.Security needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration new-api-needs-documentation

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bartonjs @vcsjones