Revert "Always use live host" #72628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c4277b9.
Member
Author
|
fyi @hoyosjs @ViktorHofer |
hoyosjs
approved these changes
Jul 21, 2022
Member
|
Sad... was the subset build not enough in the other fix you had? |
Member
Author
|
No, still has problems with installer. I think I'll be able to track it down, but it'll involve reproing exactly what's happening locally and running some individual tests. |
agocke
added a commit
to agocke/runtime
that referenced
this pull request
Jul 29, 2022
This reverts commit 63692cd.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #71725
Unfortunately this causes the host to appear in the shared runtime, which it shouldn't. If I only copy it
over to the live runtimepack during libs.tests it doesn't appear in the installer hosts tests.