Delete reachable Debug.Fail in regex generator codefix#72534
Merged
joperezr merged 4 commits intodotnet:mainfrom Jul 20, 2022
Merged
Delete reachable Debug.Fail in regex generator codefix#72534joperezr merged 4 commits intodotnet:mainfrom
joperezr merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
area-System.Text.RegularExpressions
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsFixes #72085
|
Youssef1313
changed the title
Youssef1313
force-pushed
the
debug-fail-regex-gen
branch
from
6224c7e to
32f8a2c
Compare
Member
Author
|
@joperezr Can you take a look? Thanks! |
joperezr
reviewed
Jul 20, 2022
...System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToRegexGeneratorAnalyzerTests.cs
Show resolved
Hide resolved
joperezr
reviewed
Jul 20, 2022
...System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToRegexGeneratorAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Jul 20, 2022
...System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToRegexGeneratorAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
joperezr
approved these changes
Jul 20, 2022
Member
|
Thanks a bunch for the contribution @Youssef1313, will merge as soon as build finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72085