Fix chain cleanup in SslStream.SelectClientCertificate #72222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chain's elements are being disposed of _after_ the chain itself is being disposed of, which means none of the elements are actually being disposed (chain.Dispose nulls out the collection such that accessing the property again lazily initializes it to an empty one).
ghost
assigned
Member
Member
Author
I believe I addressed it in #72221. Is there another case I missed? |
Member
|
no, I look at the source code. #72221 is still on my TODO list to look at. |
bartonjs
approved these changes
Jul 14, 2022
Member
Because this would be surprising: X509Certificate2 issuerCert;
using (X509Chain chain = new X509Chain())
{
...
chain.Build(...);
issuerCert = chain.ChainElements[1].Certificate;
}
// ObjectDisposedException?!
Console.WriteLine(issuerCert.Subject);The caller owns the instances. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chain's elements are being disposed of after the chain itself is being disposed of, which means none of the elements are actually being disposed (chain.Dispose nulls out the collection such that accessing the property again lazily initializes it to an empty one).