Fix some SafeHandle finalization in System.Net.Security #72189
Conversation
There's still a lot more, but most of it appears to be inevitable given the current design and public APIs in the library, e.g. SslStreamCertificateContext creating resources it internally stores and not providing any way to explicitly clean them up.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsThere's still a lot more, but most of it appears to be inevitable given the current design and public APIs in the library, e.g. SslStreamCertificateContext creating resources it internally stores and not providing any way to explicitly clean them up. Some of the changes here are in production code in System.Security.Cryptography and System.Net.Security, but the majority are in tests.
|
wfurt
left a comment
wfurt
left a comment
There was a problem hiding this comment.
LGTM.
Is there some trick how to find all lingering safe handles or this is mostly based on code inspection? I'm wondering if it would be possible to automate this somehow....
I added instrumentation to SafeHandle earlier in the week. Do a debug or checked build of the runtime, e.g. |
3 participants
There's still a lot more, but most of it appears to be inevitable given the current design and public APIs in the library, e.g. SslStreamCertificateContext creating resources it internally stores and not providing any way to explicitly clean them up.
Some of the changes here are in production code in System.Security.Cryptography and System.Net.Security, but the majority are in tests.