Fix more SafeHandle cleanup in Windows crypto PAL #72116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these are actually on the success path. These were highlighted via the System.Net.WebSockets.Client tests with the new checked SafeHandle finalization flag.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsMost of these are actually on the success path. These were highlighted via the System.Net.WebSockets.Client tests with the new checked SafeHandle finalization flag.
|
bartonjs
reviewed
Jul 13, 2022
...ryptography/src/System/Security/Cryptography/X509Certificates/ChainPal.Windows.BuildChain.cs
Show resolved
Hide resolved
bartonjs
reviewed
Jul 13, 2022
...ty.Cryptography/src/System/Security/Cryptography/X509Certificates/StorePal.Windows.Import.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Jul 13, 2022
Member
bartonjs
left a comment
bartonjs
left a comment
There was a problem hiding this comment.
Couple small things, but it overall looks good.
Co-authored-by: Jeremy Barton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are actually on the success path. These were highlighted via the System.Net.WebSockets.Client tests with the new checked SafeHandle finalization flag.