Fix annotation on XmlElement constructor parameter#71860
Fix annotation on XmlElement constructor parameter#71860stephentoub merged 4 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-xml |
…and namespace URI
src/libraries/System.Xml.ReaderWriter/ref/System.Xml.ReaderWriter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/XPath/XPathNavigator.cs
Outdated
Show resolved
Hide resolved
|
Thanks! |
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
|
@stephentoub was the breaking change you were identifying here the change to permit a null string in the virtual methods? @dotnet/area-system-xml can you help submit the document? |
Yes. It's minor, but anyone who was deriving from these types and overriding these methods and who had nullable reference types enabled will now get a compiler warning due to having overrides which say they don't accept nullable when the base virtual now says it does. (In previous releases, we've had a single breaking change notification that mopped up all of the annotation changes in the release. We might want to do something similar here, if there are others. cc: @jeffhandley) |
Fixes #71858