Skip to content

JIT: Remove some fgWalkTree uses #71767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 1 commit into from
Jul 8, 2022
Merged

JIT: Remove some fgWalkTree uses #71767

jakobbotsch merged 1 commit into from
Jul 8, 2022

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Jul 7, 2022 •
edited
Loading

Convert them to GenTreeVisitor.

Hoping to offset the TP cost from potentially removing BBF_HAS_NULLCHECK and BBF_HAS_IDX_LEN in #71707...

@jakobbotsch
JIT: Remove some fgWalkTree uses
7617d78 
Convert them to GenTreeVisitor.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 7, 2022
@ghost ghost assigned jakobbotsch Jul 7, 2022
@ghost
Copy link

ghost commented Jul 7, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Convert them to GenTreeVisitor.

Hoping to offset the TP cost from potentially removing BBF_HAS_NULLCHECK and BBF_HAS_ARR_IDX in #71707...

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jul 7, 2022 •
edited
Loading

cc @dotnet/jit-contrib
No diffs, only TP improvements that should roughly offset the cost of #71707.

windows x64

Collection PDIFF
benchmarks.run.windows.x64.checked.mch -0.34%
coreclr_tests.pmi.windows.x64.checked.mch -0.36%
libraries.crossgen2.windows.x64.checked.mch -0.31%
libraries.pmi.windows.x64.checked.mch -0.29%
libraries_tests.pmi.windows.x64.checked.mch -0.32%


@EgorBo
Copy link
Member

EgorBo commented Jul 7, 2022

TP might be improved even more after native PGO I'd guess 🙂

@jakobbotsch jakobbotsch merged commit fdb900e into dotnet:main Jul 8, 2022
@jakobbotsch jakobbotsch deleted the more-walkers branch July 8, 2022 08:42
@ghost ghost locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakobbotsch @EgorBo @BruceForstall