STJ: Add AggressiveInlining to CheckNotDisposed() #71534
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsImproves performance for the #67176 benchmark (it regressed due to a different reason, but this looks like a low-hanging fruit and other workloads/benchmarks will benefit from this as well) private void CheckNotDisposed()
{
if (_utf8Json.IsEmpty)
{
throw new ObjectDisposedException(nameof(JsonDocument));
}
}Currently, JIT rarely inlines methods with
|
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.cs
Outdated
Show resolved
Hide resolved
The fundamental blocker here is making partial compilation work when we're optimizing code. For unoptimized code it's not hard to figure out where all the continuation state is located since Tier0 codegen is very simplistic, but for optimized code.... But in cases like this where there is no live continuation state (that is, if the throw does not refer to any locals), perhaps it would be not too hard even when optimizing. |
4 participants
Improves performance for the #67176 benchmark (it regressed due to a different reason, but this looks like a low-hanging fruit and other workloads/benchmarks will benefit from this as well)
Currently, JIT rarely inlines methods with
throwinside (mostly only when it sees foldable branches, etc.) because it knows that they usually come with a lot of size increase for the caller. Technically, it's not a big deal since suchthrowrelated pieces will be marked as cold and won't be involved. However, I think we need to wait for "partial compilation" feature in the JIT to be less conservative (because throw-blocks won't be even compiled) here or otherwise will see a huge positive jit-diffs.