Regression test for GitHub issue #71319 #71461
Conversation
ghost
assigned
|
Thank you for adding the regression test! Looks like it's asserting the checked legs, so we actually found something interesting! |
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
The test looks good. Maybe we could check it in ActiveIssue'd. Looks like the Mono team also has a bug to look at.
|
Hmm, that is weird, I believe I tested the test locally in debug mode and I didn't see any assertions although this one looks deterministic. I'll take a first look to get more info regarding how we should proceed here. Thanks Michal for reviewing! |
trylek
force-pushed
the
RegressionTestGitHub71319
branch
from
1a14b47 to
0bcd1bb
Compare
|
I have managed to repro the failure locally - it was a bit tricky as it only reproes when tiered compilation is turned off. According to my understanding the problem is that |
trylek
force-pushed
the
RegressionTestGitHub71319
branch
from
0bcd1bb to
26b9035
Compare
|
I have blocked out the failing Mono version of the test and the PR pipeline is green now. @davidwrighton, could you please review the runtime change to double-check that it's functionally equivalent? |
|
Considering David is on vacation this week I'm inclined to merge this in before today Preview 7 fork as it fixes an important CoreCLR runtime bug; I'll address any feedback David might have in a follow-up change once he's back. Assuming there's no pushback I'll merge this in after 2PM today. |
2 participants
I have created a regression test to cover the scenario described in the GitHub issue.
In runtime main the test is passing now for me so I don't think there's anything to
investigate right now.
Thanks
Tomas
Fixes: #71319