Fix some tests regressed by the aggressive reflection metadata trimming work#71440
Merged
LakshanF merged 2 commits intodotnet:mainfrom Jul 1, 2022
Merged
Fix some tests regressed by the aggressive reflection metadata trimming work#71440LakshanF merged 2 commits intodotnet:mainfrom
LakshanF merged 2 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
approved these changes
Jun 30, 2022
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Looks good!
Could you please file an issue to get rid of the IlcTrimMetadata (and add a link to the issue from each of the CSPROJ)? IlcTrimMetadata is not a shipping configuration and I would like us to test the shipping configuration.
Basically, if the test is failing because the test itself is doing some unanalyzable reflection that targets the framework, we should either make the test analyzable, or add RD.XML. If the test is failing because the framework itself is doing some reflection, that's potentially a product bug that we would want to look at in detail.
We test IlcTrimMetadata in a targeted test under src/test/nativeaot.
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 21, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aggressive reflection trimming PR, #70201 regressed some library tests and that PR just missed the RR enabling effort that came soon after (so the regressions couldn't be caught at that time). Getting these tests to pass again by setting
IlcTrimMetadatato false.There are some other tests that require a deeper investigation since the error message looks puzzling at first glance,