Use u8 string in CultureNames #71417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsFirst commit updates toolset version and applies @AaronRobinsonMSFT's lifetime patch from dotnet/installer#14029. Second commit uses u8 string for CultureNames, and updates its generator. File size of
|
Member
|
@am11 Those changes are really a point in time and shouldn't be checked into main. Moving to a new compiler with |
danmoseley
reviewed
Jun 29, 2022
src/libraries/System.Private.CoreLib/src/System/Globalization/IcuLocaleData.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@AaronRobinsonMSFT, could you please rebase that branch current |
Member
|
Let's please wait to do this PR until Aaron's changes that bring in a new compiler have all landed. There's no rush on this PR as it's purely maintainability. Thanks. |
Member
I should be able to get that in a PR today or tomorrow. |
Member
Author
|
Compiler is crashing with Stack Overflow (on Windows and Applie's OSes): /Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : Stack overflow. [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : Repeat 339 times: [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : -------------------------------- [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.Binder.CheckValEscape(Microsoft.CodeAnalysis.SyntaxNode, Microsoft.CodeAnalysis.CSharp.BoundExpression, UInt32, UInt32, Boolean, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : -------------------------------- [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.Binder.ValidateEscape(Microsoft.CodeAnalysis.CSharp.BoundExpression, UInt32, Boolean, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.Binder.<BindExpressionBodyAsBlock>g__bindExpressionBodyAsBlockInternal|960_0(Microsoft.CodeAnalysis.CSharp.Syntax.ArrowExpressionClauseSyntax, Microsoft.CodeAnalysis.CSharp.Binder, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.Binder.BindExpressionBodyAsBlock(Microsoft.CodeAnalysis.CSharp.Syntax.ArrowExpressionClauseSyntax, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.Binder.BindMethodBody(Microsoft.CodeAnalysis.CSharp.CSharpSyntaxNode, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.MethodCompiler.BindMethodBody(Microsoft.CodeAnalysis.CSharp.Symbols.MethodSymbol, Microsoft.CodeAnalysis.CSharp.TypeCompilationState, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag, Boolean, Microsoft.CodeAnalysis.CSharp.BoundNode, Boolean, Microsoft.CodeAnalysis.CSharp.ImportChain ByRef, Boolean ByRef, Boolean ByRef, InitialState ByRef) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.MethodCompiler.CompileMethod(Microsoft.CodeAnalysis.CSharp.Symbols.MethodSymbol, Int32, ProcessedFieldInitializers ByRef, Microsoft.CodeAnalysis.CSharp.SynthesizedSubmissionFields, Microsoft.CodeAnalysis.CSharp.TypeCompilationState) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.MethodCompiler.CompileNamedType(Microsoft.CodeAnalysis.CSharp.Symbols.NamedTypeSymbol) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Microsoft.CodeAnalysis.CSharp.MethodCompiler+<>c__DisplayClass25_0.<CompileNamedTypeAsync>b__0() [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at Roslyn.Utilities.UICultureUtilities+<>c__DisplayClass5_0.<WithCurrentUICulture>b__0() [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(System.Threading.Thread, System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread) [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at System.Threading.ThreadPoolWorkQueue.Dispatch() [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart() [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
/Users/runner/work/1/s/.packages/microsoft.net.compilers.toolset/4.4.0-1.22328.22/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : at System.Threading.Thread.StartCallback() [/Users/runner/work/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]@AlekseyTs, is it a known issue? |
Member
Author
Reported dotnet/roslyn#62361 with additional info in case it wasn't. |
Member
The roslyn issue was fixed. Updated roslyn packages are usually available within a day on the internal feeds ( |
stephentoub
force-pushed
the
feature/u8-strings
branch
from
74f14c7 to
89d9151
Compare
Member
Yup. @jcouv do you know what min version has the fix? |
Member
Author
|
I think we would need to wait for the next v4.4.0-x to pick up the change. (the subsequent automation PR after dotnet/roslyn#62492 is merged or abandoned). |
Member
Not precisely, but the fix was merged only 2 hours ago. I'd suggest checking the internal feed in a day or two. |
Member
|
Gotcha, I read your previous note too quickly and thought it was fixed before today. We'll wait :-) |
am11
commented
Jul 9, 2022
stephentoub
approved these changes
Jul 9, 2022
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit updates toolset version and applies @AaronRobinsonMSFT's lifetime patch from dotnet/installer#14029.Second commit uses u8 string for CultureNames, and updates its generator. File size of
IcuLocaleData.csgoes from 277740 to 227081 (bytes).