Improve allocations and startup in HashAlgorithmNames #71341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsThere are only 5 hash algorithm names, we can just use a couple of if's instead of a
|
am11
reviewed
Jun 27, 2022
...ibraries/System.Security.Cryptography/src/System/Security/Cryptography/HashAlgorithmNames.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only 5 hash algorithm names, we can just use a couple of if's instead of a
HashSet. This removes the static constructor forHashAlgorithmNames, andToUpperdoesn't allocate a new upper-case string every time it's used. Also fixes a typo in the parameter name.