Disable LTCG when building libnethost.lib for Windows.#71089
Merged
agocke merged 1 commit intodotnet:mainfrom Jun 29, 2022
alexrp:libnethost-disable-ltcg
Merged
Disable LTCG when building libnethost.lib for Windows.#71089agocke merged 1 commit intodotnet:mainfrom alexrp:libnethost-disable-ltcg
agocke merged 1 commit intodotnet:mainfrom
alexrp:libnethost-disable-ltcg
Conversation
ghost
added
area-Infrastructure-coreclr
community-contribution
|
Tagging subscribers to this area: @hoyosjs Issue DetailsFixes #71056.
|
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsFixes #71056.
|
Member
|
/cc @elinor-fung |
AaronRobinsonMSFT
approved these changes
Jun 22, 2022
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
LGTM.
I'd like to see @vitek-karas or @elinor-fung sign off on this too.
Contributor
Author
|
By the way, is it possible for this and #71205 to make it into the next .NET 7 preview? |
Member
|
@alexrp Preview 6 has already snapped I believe. It will be in Preview 7 for sure. |
elinor-fung
approved these changes
Jun 28, 2022
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71056.