Skip to content

Various cryptographic allocation improvements #71015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vcsjones merged 7 commits into from
Jul 2, 2022
Merged

Various cryptographic allocation improvements #71015

vcsjones merged 7 commits into from
Jul 2, 2022

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Jun 20, 2022

Removes some allocations, or use some span-friendly APIs where available.

@ghost ghost added the area-System.Security label Jun 20, 2022
@ghost ghost assigned vcsjones Jun 20, 2022
@ghost
Copy link

ghost commented Jun 20, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Removes some allocations, or use some span-friendly APIs where available.

Author: vcsjones
Assignees: -
Labels:

area-System.Security
Milestone: -

vcsjones
vcsjones commented Jun 20, 2022
View reviewed changes
@vcsjones
Copy link
Member Author

vcsjones commented Jun 20, 2022

This seems to have unearthed some other odd behaviors that need investigating on Windows.

@vcsjones vcsjones marked this pull request as draft June 20, 2022 20:56
@vcsjones
Copy link
Member Author

vcsjones commented Jun 21, 2022 •
edited
Loading

This seems to have unearthed some other odd behaviors that need investigating on Windows.

TransformFinalBlock and the symmetric one-shots differ in how they handle zero-length input.

@vcsjones vcsjones marked this pull request as ready for review June 21, 2022 00:37
@vcsjones
Copy link
Member Author

vcsjones commented Jul 1, 2022

I'd feel better with an outer loop run given how many tests in Pkcs are outer loop.

/azp run runtime-libraries-coreclr outerloop

@vcsjones
Copy link
Member Author

vcsjones commented Jul 1, 2022

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 1, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones
Copy link
Member Author

vcsjones commented Jul 2, 2022 •
edited
Loading

The System.Runtime.Tests outer loop failure in Linux and Linux-Musl is an OOM kill and tracked in #58616.

@vcsjones vcsjones merged commit 945e7eb into dotnet:main Jul 2, 2022
@vcsjones vcsjones deleted the crypto-perf branch July 2, 2022 01:26
@ghost ghost locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjs bartonjs bartonjs approved these changes

+1 more reviewer

@sdrapkin sdrapkin sdrapkin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vcsjones vcsjones

Labels

area-System.Security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vcsjones @sdrapkin @bartonjs