Skip to content

Avoid some unnecessary signed casts #70884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 1 commit into from
Jun 27, 2022
Merged

Avoid some unnecessary signed casts #70884

jakobbotsch merged 1 commit into from
Jun 27, 2022

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Jun 17, 2022

We do not need a signed cast if we know the sign bit is already zero.

@jakobbotsch
Avoid some unnecessary unsigned -> signed casts
aabb7b9 
We do not need a signed cast if we know the sign bit is already zero.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 17, 2022
@ghost ghost assigned jakobbotsch Jun 17, 2022
@ghost
Copy link

ghost commented Jun 17, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

We do not need a signed cast if we know the sign bit is already zero.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch changed the title Avoid some unnecessary unsigned -> signed casts Avoid some unnecessary signed casts Jun 17, 2022
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jun 17, 2022 •
edited
Loading

This fixes an assertion in the tailcall validation seen in the Fuzzlyn run in #70222.

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jun 17, 2022

Minor diffs. Mainly this is just fixing another case where the inliner was inserting unnecessary IR after a tailcall.

cc @dotnet/jit-contrib PTAL @EgorBo

@jakobbotsch jakobbotsch requested a review from EgorBo June 17, 2022 14:38
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jun 21, 2022

ping @EgorBo

1 similar comment
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jun 27, 2022

ping @EgorBo

@jakobbotsch jakobbotsch merged commit a052819 into dotnet:main Jun 27, 2022
@jakobbotsch jakobbotsch deleted the expand-fgCastNeeded branch June 27, 2022 11:07
@kunalspathak kunalspathak mentioned this pull request Jul 20, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch @EgorBo