[mono][wasm] Avoid falling back to the interpreter for generic delegate invocation #70653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_shared_method_full (). Previously, we computed the shared version of the wrapper created from the invoke method on the generic type definition. This always returned a shared instance with ref gparams even if the original method had valuetype generic arguments.
Previously, these were added using add_method (), which didn't try to use generic sharing, so the actual instance was added, and the shared version was not. This led to increased executable size and the shared versions were not found at runtime, causing fallbacks to the interpreter.
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
approved these changes
Jun 13, 2022
lewing
approved these changes
Jun 13, 2022
Member
Contributor
|
🚀🚀🚀 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.