Skip X.509 extension copies where possible #70589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsThere are a few places where we take a strongly typed object for an This PR introduces an internal constructor that skips the copy for the places where we know that the data going in to This also adds a cached Oid instance for the AIA extension.
|
bartonjs
approved these changes
Jun 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places where we take a strongly typed object for an
X509Extension, serialize it to bytes, and then pass it to a base constructor, which copies it.This PR introduces an internal constructor that skips the copy for the places where we know that the data going in to
AsnEncodedDatacan have ownership of the data being passed.This also adds a cached Oid instance for the AIA extension.