Fix trimmability of various System.Runtime tests#70329
Merged
jkotas merged 2 commits intodotnet:mainfrom Jun 7, 2022
Merged
Conversation
The reflection patterns couldn't be statically analyzed. Needed to unblock dotnet#70201. NativeAOT trims by default and CoreLib is marked trimmable.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-system-text-encoding Issue DetailsThe reflection patterns couldn't be statically analyzed. Needed to unblock #70201. NativeAOT trims by default and CoreLib is marked trimmable.
|
jkotas
reviewed
Jun 7, 2022
| private static Type GetAsciiUtilityType() | ||
| { | ||
| return typeof(object).Assembly.GetType("System.Text.ASCIIUtility"); | ||
| return Type.GetType("System.Text.ASCIIUtility"); |
Member
There was a problem hiding this comment.
Add , System.Private.CoreLib to make the assembly name explicit?
jkotas
approved these changes
Jun 7, 2022
MichalStrehovsky
commented
Jun 7, 2022
src/libraries/System.Runtime/tests/System/Text/ASCIIUtilityTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Text/Latin1UtilityTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Text/Unicode/Utf16UtilityTests.ValidateChars.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Text/Unicode/Utf8UtilityTests.ValidateBytes.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reflection patterns couldn't be statically analyzed.
Needed to unblock #70201. NativeAOT trims by default and CoreLib is marked trimmable.