Always use portable tailcalling mechanism for delegate tailcalls#70269
Merged
BruceForstall merged 5 commits intodotnet:mainfrom Jun 7, 2022
Merged
Always use portable tailcalling mechanism for delegate tailcalls#70269BruceForstall merged 5 commits intodotnet:mainfrom
BruceForstall merged 5 commits intodotnet:mainfrom
Conversation
It is rare but possible to have delegates that point to VSD stubs. Since VSD stubs on x86 may disassemble the call-site we cannot allow tail calling these with the old mechanism. Fix dotnet#70259
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIt is rare but possible to have delegates that point to VSD stubs. Since Fix #70259
|
Tailcall through built-in delegates is best-effort. Instantiating stubs may break the chain and on ARM32 so may wrapper delegate stubs. The latter happens for this particular test. Change the test so that it is just verifying we do not hit the assert.
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo |
EgorBo
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is rare but possible to have delegates that point to VSD stubs. Since
VSD stubs on x86 may disassemble the call-site we cannot allow tail
calling these with the old mechanism.
Fix #70259