Do not retype SIMD nodes #70265
Merged
Do not retype SIMD nodes #70265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
It is not necessary: the only case where it is required, SIMD8 to LONG bitcasts on Windows x64, is already handled by lowering. It is dangerous: in case we CSE the retyped tree, its other uses will be (effectively) retyped as well.
SingleAccretion
force-pushed
the
No-Simd-Retyping
branch
from
009ab99 to
55b6671
Compare
Contributor
Author
|
@dotnet/jit-contrib We need a libraries stress run for this change. |
Contributor
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
Stress failure: Libraries stress failures:
@dotnet/jit-contrib |
BruceForstall
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70124.
Fixes #70260.
No diffs as expected.