Fix long latencies in ReaderWriterLockSlim lock operations due to Sleep(1)
#70165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Sleep(1)` - Removed usage of `Sleep(1)` - Modified the spin-waiting scheme beyond the `Sleep(0)` threshold to avoid potentially long sequences of ineffective `Sleep(0)`s - Retuned the threshold to reprioritize deprioritized spin-lock requests Fixes #69206
ghost
assigned
|
Tagging subscribers to this area: @mangod9 Issue Details
Fixes #69206
|
Contributor
Author
|
On the test case in the fixed issue, the output is mostly empty (no latency higher than 0.5 ms), with the occasional ~1 ms latency. There is some tradeoff in throughput when there is high contention on the spin-lock, in favor of avoiding very high latencies, with this change. It seems like a necessary and reasonable tradeoff, since the higher throughput in the baseline is mainly artificial due to the |
stephentoub
reviewed
Jun 29, 2022
src/libraries/System.Private.CoreLib/src/System/Threading/ReaderWriterLockSlim.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sleep(1)Sleep(0)threshold to avoid potentially long sequences of ineffectiveSleep(0)sFixes #69206