Update analyzer version and fix new findings #70157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsDogfooding the new analyzer
|
buyaa-n
commented
Jun 2, 2022
stephentoub
reviewed
Jun 2, 2022
src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 2, 2022
src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 2, 2022
src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 2, 2022
stephentoub
reviewed
Jun 2, 2022
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/DbConnectionOptions.cs
Outdated
Show resolved
Hide resolved
skundlony
approved these changes
Jun 2, 2022
2 tasks
stephentoub
reviewed
Jun 9, 2022
stephentoub
approved these changes
Jun 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dogfooding the new analyzer
CA1854: Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' methodthat developed by @CollinAlpert. Fixing the findings