Skip to content

Conversation

@stephentoub
Copy link
Member

Separated out of #69995

@stephentoub stephentoub requested a review from marek-safar as a code owner June 1, 2022 14:46
@ghost ghost assigned stephentoub Jun 1, 2022
@ghost
Copy link

ghost commented Jun 1, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@stephentoub
Copy link
Member Author

stephentoub commented Jun 1, 2022

@tannergooding, this PR has the same mono Unix generic math failures I mentioned in #69995 (comment). Could you take a look?

@tannergooding
Copy link
Member

@stephentoub this looks like an issue similar to #69795.

I'd recommend disabling them just for Mono since its handling it incorrectly (looks like its always treating the target type as int/uint even on 64-bit systems)

@stephentoub
Copy link
Member Author

stephentoub commented Jun 1, 2022

I'd recommend disabling them just for Mono

Ok. I'll disable them for mono against that issue.

@stephentoub stephentoub merged commit 0bdf195 into dotnet:main Jun 2, 2022
@stephentoub stephentoub deleted the updatecompiler branch June 2, 2022 02:43
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants