Make gcunsafe for cpblk if it has gc pointers #70053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT |
This was referenced May 31, 2022
Member
|
Is it possible to backport this into preview 5? Otherwise when the SDK propagates we will probably end up with spurious CI failures due to this. |
BruceForstall
approved these changes
May 31, 2022
Contributor
Author
|
/backport to release/7.0-preview5 |
Contributor
|
Started backporting to release/7.0-preview5: https://github.com/dotnet/runtime/actions/runs/2419458238 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While refactoring #69202 I missed a case where we would not mark a region as GC unsafe for store block that might have GC pointers.
Fixes: #69657