Add support for processing Unified TLS frames #69848
Conversation
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsThis is mix of #68425, dotnet/yarp#1656 and reaction to #64322. Unified parsing works only on Windows as legacy and allows (old) clients to send TLS frame encoded in Ssl2 format. Since the header size is now variable, I changed Since we don't have good way how to generate real traffic, I added test that injects legacy ClientHello and verifies that we get back ServerHello instead of failure. fixes #68310
|
|
/azp run runtime |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamNetworkStreamTest.cs
Show resolved
Hide resolved
|
test failures are unrelated to SslStream. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
This is mix of #68425, dotnet/yarp#1656 and reaction to #64322.
Unified parsing works only on Windows as legacy and allows (old) clients to send TLS frame encoded in Ssl2 format.
All we really need is to process first frame. Server should respond back with "normal" TLS e.g. all the framing and processing removed in #64322 is really not needed.
Since the header size is now variable, I changed
TlsFrameHelperto return length of the TLS frame instead of just length of the inner payload.Since we don't have good way how to generate real traffic, I added test that injects legacy ClientHello and verifies that we get back ServerHello instead of failure.
fixes #68310