Use stack buffers and return data to pool in EC point encoding #69812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsThis all started because
|
Member
Author
|
I'm super confused by CI. It appears to be running jitstress and outer loop for some reason. |
bartonjs
approved these changes
May 25, 2022
Member
|
#69813 sees the same failures launching the Quic tests, and everything seems to be launching jitstress and outerloop with no access token... so... merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This all started because
WriteUncompressedPublicKeywas renting fromCryptoPooland never returning the rented buffer. So I fixed that. But oh, wait, these buffers fit pretty comfortably in the stack, so let's do that while we're here.