-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Remove more uses of StringBuilderCache #69683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
|
Do you anticipate any reason we wouldn't ultimately be able to delete SBC? It is hard to think of a place we use it today that could not be refactored away one way or another. |
There are always alternatives, and it's just a question of whether those alternatives are better for a given use. The primary benefit StringBuilder / StringBuilderCache can have in some situations is that it's segmented, such that other than for the final resulting string, you don't necessarily incur very large allocations, instead potentially incurring more, smaller allocations. It's just something to think about on a case-by-case basis, e.g. we'll need to think more about it for one of the two remaining uses in corelib, BinaryReader.ReadString. |
36efaa4 to
f13780c
Compare
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue Detailsnull
|
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/AggregateException.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormat.cs
Outdated
Show resolved
Hide resolved
GrabYourPitchforks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off on commit 3c38781.
No description provided.