Skip to content

Conversation

@stephentoub
Copy link
Member

No description provided.

@ghost ghost assigned stephentoub May 23, 2022
@ghost ghost added the area-System.Net.Http label May 23, 2022
@ghost
Copy link

ghost commented May 23, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Net.Http

Milestone: -

@danmoseley
Copy link
Member

Do you anticipate any reason we wouldn't ultimately be able to delete SBC? It is hard to think of a place we use it today that could not be refactored away one way or another.

@stephentoub
Copy link
Member Author

Do you anticipate any reason we wouldn't ultimately be able to delete SBC? It is hard to think of a place we use it today that could not be refactored away one way or another.

There are always alternatives, and it's just a question of whether those alternatives are better for a given use. The primary benefit StringBuilder / StringBuilderCache can have in some situations is that it's segmented, such that other than for the final resulting string, you don't necessarily incur very large allocations, instead potentially incurring more, smaller allocations. It's just something to think about on a case-by-case basis, e.g. we'll need to think more about it for one of the two remaining uses in corelib, BinaryReader.ReadString.

@ghost
Copy link

ghost commented May 24, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Runtime

Milestone: -

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off on commit 3c38781.

@stephentoub stephentoub merged commit f002cdc into dotnet:main Jun 1, 2022
@stephentoub stephentoub deleted the moresbcache branch June 1, 2022 21:24
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants