Skip to content

Profiler RequestReJITWithInliners did not work properly if all methods in the module were not loaded#69634

Merged
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:rejit_inliner_bugs
May 21, 2022
Merged

Profiler RequestReJITWithInliners did not work properly if all methods in the module were not loaded#69634
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:rejit_inliner_bugs

Conversation

@davidwrighton

Copy link
Copy Markdown
Member
  • Add unused functions into rejit.cs test to expose the problematic behavior
  • Fix by using tokens throughout the handling of R2R inlining information instead of converting to MethodDescs at times

…s in the module were not loaded

- Add unused functions into rejit.cs test to expose the problematic behavior
- Fix by using tokens throughout the handling of R2R inlining information instead of converting to MethodDescs at times
@ghost

ghost commented May 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add unused functions into rejit.cs test to expose the problematic behavior
  • Fix by using tokens throughout the handling of R2R inlining information instead of converting to MethodDescs at times
Author: davidwrighton
Assignees: davidwrighton
Labels:

area-Diagnostics-coreclr

Milestone: -

@davmason davmason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwrighton
davidwrighton merged commit 9a5387b into dotnet:main May 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 20, 2022
@davidwrighton
davidwrighton deleted the rejit_inliner_bugs branch April 13, 2023 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants