Optimize ManifestResourceStream.Read(Span<byte>) #69412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManifestResourceStream is derived from UnmanagedMemoryStream. UnmanagedMemoryStream optimizes Read(Span<byte>), but only if the instance is concretely an UnmanagedMemoryStream. This is to protect in case the derived Stream overriddes Read(byte[], int, int) prior to the Read(Span<byte>) overload being introduced. Optimize ManifestResourceStream by overriding Read(Span<byte>) and call ReadCore, so the Stream.Read(Span<byte>) logic of using a pooled byte[] buffer isn't used.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsManifestResourceStream is derived from UnmanagedMemoryStream. UnmanagedMemoryStream optimizes Read(Span), but only if the instance is concretely an UnmanagedMemoryStream. This is to protect in case the derived Stream overriddes Read(byte[], int, int) prior to the Read(Span) overload being introduced. Optimize ManifestResourceStream by overriding Read(Span) and call ReadCore, so the Stream.Read(Span) logic of using a pooled byte[] buffer isn't used. Benchmark[MemoryDiagnoser]
public class ManifestResourceStreamBenchmark
{
private Stream _stream;
[GlobalSetup]
public void Setup()
{
_stream = typeof(object).Assembly.GetManifestResourceStream("System.Private.CoreLib.Strings.resources");
}
[Benchmark]
public void ReadAll()
{
Span<byte> buffer = stackalloc byte[1024];
while (_stream.Read(buffer) != 0)
{
}
}
}Results
|
stephentoub
approved these changes
May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManifestResourceStream is derived from UnmanagedMemoryStream. UnmanagedMemoryStream optimizes Read(Span), but only if the instance is concretely an UnmanagedMemoryStream. This is to protect in case the derived Stream overriddes Read(byte[], int, int) prior to the Read(Span) overload being introduced.
Optimize ManifestResourceStream by overriding Read(Span) and call ReadCore, so the Stream.Read(Span) logic of using a pooled byte[] buffer isn't used.
Benchmark
Results