Skip to content

Enable System.Globalization.Native for NativeAOT #69297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 1 commit into from
May 13, 2022
Merged

Enable System.Globalization.Native for NativeAOT #69297

jkotas merged 1 commit into from
May 13, 2022

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented May 13, 2022

Fixes #68889

@jkotas jkotas requested a review from MichalStrehovsky as a code owner May 13, 2022 06:01
@ghost ghost assigned jkotas May 13, 2022
@jkotas jkotas requested review from LakshanF and agocke May 13, 2022 12:31
LakshanF
LakshanF approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the perf test, "System.Globalization.Tests.StringEquality.Compare_Same", from the performance repo is showing improvements with this change now

@jkotas jkotas merged commit 9d06449 into dotnet:main May 13, 2022
@adamsitnik
Copy link
Member

adamsitnik commented May 16, 2022

I assume the perf test, "System.Globalization.Tests.StringEquality.Compare_Same", from the performance repo is showing improvements with this change now

It is!

Method Runtime Options Mean Ratio
Compare_Same .NET 7.0 (, IgnoreCase) 769.87 ns 1.00
Compare_Same NativeAOT 7.0 (, IgnoreCase) 763.26 ns 0.99
Compare_Same .NET 7.0 (, None) 768.71 ns 1.00
Compare_Same NativeAOT 7.0 (, None) 763.40 ns 0.99
Compare_Same .NET 7.0 (en-US, IgnoreCase) 766.54 ns 1.00
Compare_Same NativeAOT 7.0 (en-US, IgnoreCase) 763.63 ns 1.00
Compare_Same .NET 7.0 (en-US, IgnoreNonSpace) 764.08 ns 1.00
Compare_Same NativeAOT 7.0 (en-US, IgnoreNonSpace) 760.61 ns 1.00
Compare_Same .NET 7.0 (en-US, IgnoreSymbols) 764.83 ns 1.00
Compare_Same NativeAOT 7.0 (en-US, IgnoreSymbols) 762.80 ns 1.00
Compare_Same .NET 7.0 (en-US, None) 772.08 ns 1.00
Compare_Same NativeAOT 7.0 (en-US, None) 763.99 ns 0.99
Compare_Same .NET 7.0 (en-US, Ordinal) 33.49 ns 1.00
Compare_Same NativeAOT 7.0 (en-US, Ordinal) 32.95 ns 0.98
Compare_Same .NET 7.0 (en-US, OrdinalIgnoreCase) 749.46 ns 1.00
Compare_Same NativeAOT 7.0 (en-US, OrdinalIgnoreCase) 744.45 ns 0.99
Compare_Same .NET 7.0 (pl-PL, None) 765.65 ns 1.00
Compare_Same NativeAOT 7.0 (pl-PL, None) 767.60 ns 1.00

@LakshanF LakshanF mentioned this pull request May 25, 2022
Merged
@jkotas jkotas deleted the globalization branch June 6, 2022 16:39
@ghost ghost locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

@agocke agocke Awaiting requested review from agocke

1 more reviewer

@LakshanF LakshanF LakshanF approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkotas jkotas

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[NativeAOT] Not using ICU on Windows by default

3 participants

@jkotas @adamsitnik @LakshanF