Use static abstract members on two occasions. #69278
Conversation
ghost
added
the
community-contribution
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
It is good to enforce specialized binding to the interface, but I removed it because there was no apparent reason (and didn't see it in the SslStream code I linked).
There was a problem hiding this comment.
Constraining generic arguments by structs can give hint to some of the AOT compilers that they do not need to bother to create code shared by reference instantiations.
There was a problem hiding this comment.
Both T and THandler can be constrained as structs here.
There was a problem hiding this comment.
didn't see it in the SslStream code I linked
Maybe this can be done in the SslStream code too?
There was a problem hiding this comment.
There are 21 places where TAdapter : IReadWriteAdapter is being used; it would go beyond this PR's scope, better for another time.
BTW can't the AOT compilers be smarter and detect that the shared instantiation will not be used? Or is it done intentionally (my guess would be for something like a fallback for reflection)?
There was a problem hiding this comment.
Or is it done intentionally (my guess would be for something like a fallback for reflection)?
Correct. I believe that some of the AOT compilers that we have do this already ... but it is hard to do in general case due to reflection.
src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs
Outdated
Show resolved
Hide resolved
teo-tsirpanis
added
the
NO-MERGE
teo-tsirpanis
force-pushed
the
static-abstract-members
branch
from
019bf31 to
812005f
Compare
|
Feedback addressed @jkotas. |
teo-tsirpanis
removed
the
NO-MERGE
|
From Build Analysis: Known repository errors |
3 participants
I noticed that static abstract members have started being used used in regular BCL code, and used them on two occasions.